Disable automatic application start after install via Windows Installer #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arduino IDE is packaged for Windows in multiple formats: - ZIP - NSIS - Windows Installer (AKA "MSI") The interactive installer of the NSIS package makes it the best option for installation by users. The other use case for the installers is deployment by a system administrator. The Windows Installer package was added to offer an additional installer option for this specific use case. In this use case, a "silent install" will often be required. Previously, the Windows Installer package was configured to start the Arduino IDE after completing the installation. This behavior is likely to be problematic for the very use case the Windows Installer package was intended for. That configuration was not intentional, but rather a result of using whatever setting electron-builder happened to provide as a default. The behavior of the Windows Installer package is hereby changed to not run after installation. This also aligns it with the behavior of the NSIS package's silent installation (running the installer with the `/S` flag). The behavior of the NSIS installer is unchanged: - When in interactive mode: user chooses whether to start Arduino IDE - When in silent mode: Arduino IDE does not start after installation
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arduino IDE is packaged for Windows in multiple formats:
The interactive installer of the NSIS package makes it the best option for installation by users.
The other use case for the installers is deployment by a system administrator. The Windows Installer package was added to offer an additional installer option for this specific use case.
Previously, the Windows Installer package was configured to start the Arduino IDE after completing the installation. That behavior is likely to be problematic for the very use case the Windows Installer package is intended for, where a "silent install" will often be required (example). That "run after finish" configuration was not intentional, but rather a result of using whatever setting electron-builder happened to provide as a default.
The configuration of the Windows Installer package is hereby changed to not run after installation by setting the electron-builder
build.msi.runAfterFinishconfiguration key tofalse. This also aligns the Windows Installer package with the behavior of the NSIS package's silent installation (running the installer with the/Sflag).The behavior of the NSIS installer is unchanged: